From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbcon: don't suspend/resume when vc is graphics mode
Date: Tue, 05 May 2026 10:55:28 +1000 [thread overview]
Message-ID: <review-overall-20260430060137.131107-1-yaolu@kylinos.cn> (raw)
In-Reply-To: <20260430060137.131107-1-yaolu@kylinos.cn>
Overall Series Review
Subject: fbcon: don't suspend/resume when vc is graphics mode
Author: yaolu@kylinos.cn
Patches: 1
Reviewed: 2026-05-05T10:55:28.147234
---
This is a single patch that adds `KD_GRAPHICS` mode checks to `fbcon_suspended()` and `fbcon_resumed()`, skipping cursor clearing and screen updating when the VC is in graphics mode. The change is **reasonable in principle** — fbcon should not manipulate the framebuffer when a userspace graphics server (e.g. Xorg) owns the display. This is consistent with the existing pattern throughout fbcon.c, where nearly every display-modifying operation is gated on `KD_TEXT` mode.
However, the patch has issues with commit message quality and there's a question about whether it's fixing the right layer (this may be papering over a deeper problem in the DRM/fbdev handoff on hotplug + suspend).
**Verdict: Needs revision** — the concept is sound, but the commit message needs improvement.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-05 0:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 6:01 [PATCH] fbcon: don't suspend/resume when vc is graphics mode yaolu
2026-05-05 0:55 ` Claude review: " Claude Code Review Bot
2026-05-05 0:55 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260430060137.131107-1-yaolu@kylinos.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox