Claude review: Add Lontium LT7911EXC eDP to MIPI DSI bridge

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Add Lontium LT7911EXC eDP to MIPI DSI bridge
Author: syyang@lontium.com
Patches: 4
Reviewed: 2026-05-05T10:47:37.467462

---

This is a v4 patch series adding a new DRM bridge driver for the Lontium LT7911EXC eDP-to-MIPI-DSI bridge chip. The binding patch (1/2) is reasonable but the driver patch (2/2) has several significant issues that need to be addressed before it can be merged:

1. **Missing mandatory atomic state helpers** — the driver uses atomic callbacks but does not provide `atomic_duplicate_state`, `atomic_destroy_state`, or `atomic_reset`, which are mandatory per the DRM bridge API contract.
2. **No MIPI DSI host attachment** — this is a bridge that outputs MIPI DSI, yet the driver never registers with or attaches to a DSI host. Every other Lontium bridge with DSI output (lt9611, lt9611uxc, lt8912b) does this. Without it, the bridge cannot actually drive a DSI panel/pipeline.
3. **Firmware upgrade runs synchronously in probe** — this blocks boot and could take a long time.
4. **Regulators left enabled on success path** after probe, wasting power until the display pipeline starts.
5. **Incomplete error handling** throughout the firmware flashing code.

The driver feels like an early skeleton that implements firmware flashing but is missing the core bridge functionality (mode detection, mode validation, DSI configuration).

---

---
Generated by Claude Code Patch Reviewer