Claude review: fbdev: Consistently define pci_device_ids using named initializers

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: fbdev: Consistently define pci_device_ids using named initializers
Author: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?=
 <u.kleine-koenig@baylibre.com>
Patches: 2
Reviewed: 2026-05-05T10:30:11.568532

---

This is a single, well-motivated mechanical cleanup patch across 21 fbdev drivers. It converts positional `struct pci_device_id` initializers to named initializers using `PCI_DEVICE()` / `PCI_VDEVICE()` helper macros. The stated motivation — preparing for an anonymous union on `driver_data` — is a legitimate kernel-wide effort, and this patch is a reasonable prerequisite since anonymous unions require designated initializers.

The conversions look correct throughout. The patch consistently replaces verbose `{vendor, device, PCI_ANY_ID, PCI_ANY_ID, 0, 0, driver_data}` patterns with readable macro-based forms, and replaces `{0, 0, 0, 0, 0, 0, 0}` terminators with `{ }`. The claim of no binary change to the compiled `pci_device_id` arrays is credible.

**Verdict: Looks good overall, with a couple of minor observations below.**

---

---
Generated by Claude Code Patch Reviewer