From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe: Do not blindly copy system CCS pages when shrinking
Date: Tue, 05 May 2026 09:41:41 +1000 [thread overview]
Message-ID: <review-overall-20260501011907.2331654-1-matthew.brost@intel.com> (raw)
In-Reply-To: <20260501011907.2331654-1-matthew.brost@intel.com>
Overall Series Review
Subject: drm/xe: Do not blindly copy system CCS pages when shrinking
Author: Matthew Brost <matthew.brost@intel.com>
Patches: 1
Reviewed: 2026-05-05T09:41:41.461905
---
This is a single patch (v2) that optimizes the xe driver's shrinker path by skipping CCS (Compression Control Surface) page copies for buffer objects that have never been mapped with a compressed PAT index. The optimization is well-motivated — the commit message reports that ~6.5x more BOs *could* have compression than actually *do*, and this cuts CCS copies roughly in half during shrinking.
The approach is sound: a new `ccs_used` boolean tracks whether a BO has ever been bound with compression enabled, and when it hasn't, CCS migration to system memory is skipped by returning a stub fence. The one-way latch (once set, never cleared) is a safe conservative design.
There are a few issues, mostly around the `vma_lock_and_validate` integration.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 23:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 1:19 [PATCH v2] drm/xe: Do not blindly copy system CCS pages when shrinking Matthew Brost
2026-05-04 23:41 ` Claude Code Review Bot [this message]
2026-05-04 23:41 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-30 19:09 [PATCH] " Matthew Brost
2026-05-05 0:06 ` Claude review: " Claude Code Review Bot
2026-05-05 0:06 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260501011907.2331654-1-matthew.brost@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox