Claude review: gpu: nova-core: add INTR_CTRL interrupt controller and CPU doorbell self-test

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: gpu: nova-core: add INTR_CTRL interrupt controller and CPU doorbell self-test
Author: Joel Fernandes <joelagnelf@nvidia.com>
Patches: 8
Reviewed: 2026-05-05T09:10:00.964370

---

This is a well-structured 7-patch series from Joel Fernandes (NVIDIA) that adds interrupt controller (INTR_CTRL) support to the nova-core GPU driver in Rust. The series progresses logically: first adds a missing Rust kernel API (`wait_for_completion_timeout`), then allocates PCI MSI vectors, defines register layouts, builds a type-state-driven interrupt controller abstraction, runs a hardware self-test, and finishes with excellent documentation.

**Strengths:**
- The type-state pattern in `intr_ctrl.rs` (Idle → Unarmed → Pending) is well-designed and catches ISR protocol mistakes at compile time.
- The documentation patch (7/7) is outstanding - thorough, with diagrams, and explains the edge-trigger/rearm semantics that are notoriously confusing.
- The self-test is behind a Kconfig option, which is appropriate.
- The series has been tested end-to-end on real hardware (GA102 passthrough).

**Issues to address:**
- Patch 2 allocates an IRQ vector but immediately drops it (the result is discarded). The vector only becomes useful in patch 6 when the self-test is configured, meaning for the normal case the allocation is wasted.
- Patch 6 has a test that succeeds silently (`Ok(())`) even on failure - it logs FAIL but returns `Ok(())` instead of `Err(EIO)`.
- A few minor style/correctness items noted below.

---

---
Generated by Claude Code Patch Reviewer