From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: add interrupt controller register definitions
Date: Tue, 05 May 2026 09:10:01 +1000 [thread overview]
Message-ID: <review-patch3-20260501205825.73614-4-joelagnelf@nvidia.com> (raw)
In-Reply-To: <20260501205825.73614-4-joelagnelf@nvidia.com>
Patch Review
```rust
pub(crate) NV_VF_INTR_LEAF(u32)[16] @ 0x00b81000 {}
pub(crate) NV_VF_INTR_LEAF_EN_SET(u32)[16] @ 0x00b81200 {}
pub(crate) NV_VF_INTR_LEAF_EN_CLEAR(u32)[16] @ 0x00b81400 {}
pub(crate) NV_VF_INTR_TOP(u32) @ 0x00b81600 {}
pub(crate) NV_VF_INTR_TOP_EN_SET(u32) @ 0x00b81608 {}
pub(crate) NV_VF_INTR_TOP_EN_CLEAR(u32) @ 0x00b81610 {}
pub(crate) NV_VF_INTR_LEAF_TRIGGER(u32) @ 0x00b81640 {}
```
Well documented register definitions. The comments explain the W1C semantics and array sizing clearly.
**Observation:** The register arrays are declared as `[16]` to cover the Hopper/Blackwell maximum. The `IntrCtrl` struct (patch 5) handles the arch-dependent active count via `subtree_mask`. This is fine - reading unused registers on pre-Hopper just returns 0 per the documentation.
**Nit:** The spacing between TOP (0x00b81600), TOP_EN_SET (0x00b81608), and TOP_EN_CLEAR (0x00b81610) shows 8-byte stride, which seems like these are 64-bit registers accessed as 32-bit. The definitions treat them as u32, which is correct for MMIO, but worth noting the layout gap.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 23:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 20:58 [PATCH v1 0/7] gpu: nova-core: add INTR_CTRL interrupt controller and CPU doorbell self-test Joel Fernandes
2026-05-01 20:58 ` [PATCH v1 1/7] rust: sync: completion: add wait_for_completion_timeout() Joel Fernandes
2026-05-04 23:10 ` Claude review: " Claude Code Review Bot
2026-05-01 20:58 ` [PATCH v1 2/7] gpu: nova-core: allocate PCI MSI vector during probe Joel Fernandes
2026-05-04 23:10 ` Claude review: " Claude Code Review Bot
2026-05-01 20:58 ` [PATCH v1 3/7] gpu: nova-core: add interrupt controller register definitions Joel Fernandes
2026-05-04 23:10 ` Claude Code Review Bot [this message]
2026-05-01 20:58 ` [PATCH v1 4/7] gpu: nova-core: add Architecture::is_pre_hopper() helper Joel Fernandes
2026-05-04 23:10 ` Claude review: " Claude Code Review Bot
2026-05-01 20:58 ` [PATCH v1 5/7] gpu: nova-core: add INTR_CTRL interrupt controller API Joel Fernandes
2026-05-04 23:10 ` Claude review: " Claude Code Review Bot
2026-05-01 20:58 ` [PATCH v1 6/7] gpu: nova-core: add CPU doorbell IRQ self-test Joel Fernandes
2026-05-04 23:10 ` Claude review: " Claude Code Review Bot
2026-05-01 20:58 ` [PATCH v1 7/7] gpu: nova-core: document INTR_CTRL interrupt tree Joel Fernandes
2026-05-04 23:10 ` Claude review: " Claude Code Review Bot
2026-05-04 23:10 ` Claude review: gpu: nova-core: add INTR_CTRL interrupt controller and CPU doorbell self-test Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260501205825.73614-4-joelagnelf@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox