From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/nouveau/kms/nvd9-: Use contiguous memory for CRC notifier context
Date: Tue, 05 May 2026 09:05:55 +1000 [thread overview]
Message-ID: <review-overall-20260501215856.840898-1-lyude@redhat.com> (raw)
In-Reply-To: <20260501215856.840898-1-lyude@redhat.com>
Overall Series Review
Subject: drm/nouveau/kms/nvd9-: Use contiguous memory for CRC notifier context
Author: Lyude Paul <lyude@redhat.com>
Patches: 2
Reviewed: 2026-05-05T09:05:55.229008
---
This is a single-patch fix for a real bug in nouveau CRC readback. The commit message is excellent: it clearly explains the symptom (CRC reads return `-EINVAL` after gnome-shell starts), the root cause (non-contiguous VRAM allocation for a hardware engine that requires contiguous memory), and why the bug is intermittent (low VRAM fragmentation under fbcon makes contiguous allocation likely by accident). The fix is correct, the error handling is sound, and the `Fixes:` / `Cc: stable` tags are appropriate.
**Recommendation: Accept.** One very minor style observation below, nothing that should block the patch.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 23:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 21:58 [PATCH] drm/nouveau/kms/nvd9-: Use contiguous memory for CRC notifier context Lyude Paul
2026-05-04 4:01 ` Dave Airlie
2026-05-04 23:05 ` Claude Code Review Bot [this message]
2026-05-04 23:05 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260501215856.840898-1-lyude@redhat.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox