From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: tc358762: Use mipi_dsi_generic_write_multi()
Date: Tue, 05 May 2026 08:59:34 +1000 [thread overview]
Message-ID: <review-overall-20260502031008.45873-1-hussain.bqadri@gmail.com> (raw)
In-Reply-To: <20260502031008.45873-1-hussain.bqadri@gmail.com>
Overall Series Review
Subject: drm/bridge: tc358762: Use mipi_dsi_generic_write_multi()
Author: Hussain Qadri <hussain.bqadri@gmail.com>
Patches: 1
Reviewed: 2026-05-05T08:59:34.716883
---
This is a single-patch series that converts the tc358762 DSI/DPI bridge driver from a hand-rolled error accumulation pattern (using `ctx->error` and `tc358762_clear_error()`) to the standard `mipi_dsi_multi_context` / `mipi_dsi_generic_write_multi()` framework provided by the DRM subsystem.
The conversion is straightforward, correct, and follows established patterns used across numerous other DSI drivers. It reduces code by ~15 lines, removes the `error` field from the driver struct, and eliminates two helper functions (`tc358762_clear_error` and the old error-checking logic in `tc358762_write`). The `mipi_dsi_generic_write_multi()` API already handles error accumulation internally via `accum_err`, providing identical semantics.
**Verdict: Looks good.** This is a clean mechanical conversion with no functional change in behavior.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 22:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-02 3:10 [PATCH v2] drm/bridge: tc358762: Use mipi_dsi_generic_write_multi() Hussain Qadri
2026-05-04 22:59 ` Claude Code Review Bot [this message]
2026-05-04 22:59 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-11 1:06 [PATCH] " Hussain Qadri
2026-04-11 23:13 ` Claude review: " Claude Code Review Bot
2026-04-11 23:13 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260502031008.45873-1-hussain.bqadri@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox