Claude review: drm/tegra: hdmi: Open-code drm_simple_encoder_init()

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/tegra: hdmi: Open-code drm_simple_encoder_init()
Author: Souradipto Das <souradiptodas6@gmail.com>
Patches: 2
Reviewed: 2026-05-16T12:11:37.822669

---

This mbox contains two versions of the same patch — v1 and v2 — by Souradipto Das, which open-codes `drm_simple_encoder_init()` in the tegra HDMI driver. The change is straightforward and mechanically correct: it replaces a call to a trivial helper with the underlying `drm_encoder_init()` call and a driver-local `drm_encoder_funcs` struct, removing the dependency on `drm_simple_kms_helper.h`. This is part of a broader cleanup effort suggested by Thomas Zimmermann.

The v2 patch fixes the stray blank line from v1. One minor style issue remains (missing blank line before the new struct), and the unchecked return value of `drm_encoder_init()` is carried over from the original code. The other tegra encoder drivers (rgb, dsi, sor) still use `drm_simple_encoder_init()` and have the same unchecked-return pattern, so this patch is consistent with the rest of the driver.

**Verdict:** The v2 patch is correct and suitable for merge, with one minor style nit.

---
Generated by Claude Code Patch Reviewer