From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915: replace select with dependency for visible DEBUG_OBJECTS
Date: Tue, 05 May 2026 08:46:43 +1000 [thread overview]
Message-ID: <review-overall-20260502191932.4491-1-julianbraha@gmail.com> (raw)
In-Reply-To: <20260502191932.4491-1-julianbraha@gmail.com>
Overall Series Review
Subject: drm/i915: replace select with dependency for visible DEBUG_OBJECTS
Author: Julian Braha <julianbraha@gmail.com>
Patches: 1
Reviewed: 2026-05-05T08:46:43.221055
---
This is a single-patch series changing `DRM_I915_SW_FENCE_DEBUG_OBJECTS` from `select DEBUG_OBJECTS` to `depends on DEBUG_OBJECTS`. The stated rationale is that `select` should not be used on user-visible symbols. While that Kconfig convention is real, this patch has a **functional regression** that makes it unsuitable for merging as-is: `DRM_I915_DEBUG` uses `select DRM_I915_SW_FENCE_DEBUG_OBJECTS` (line 62 of `Kconfig.debug`), and after this change, that `select` will silently fail whenever `DEBUG_OBJECTS` is not already enabled — breaking the intended behavior of the umbrella `DRM_I915_DEBUG` option.
**Verdict: Needs rework.**
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-04 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-02 19:19 [PATCH] drm/i915: replace select with dependency for visible DEBUG_OBJECTS Julian Braha
2026-05-04 22:46 ` Claude review: " Claude Code Review Bot
2026-05-04 22:46 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260502191932.4491-1-julianbraha@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox