From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge()
Date: Tue, 05 May 2026 08:26:08 +1000 [thread overview]
Message-ID: <review-overall-20260504-drm-bridge-alloc-getput-panel_or_bridge-v4-0-b578c3daaf10@bootlin.com> (raw)
In-Reply-To: <20260504-drm-bridge-alloc-getput-panel_or_bridge-v4-0-b578c3daaf10@bootlin.com>
Overall Series Review
Subject: drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge()
Author: Luca Ceresoli <luca.ceresoli@bootlin.com>
Patches: 19
Reviewed: 2026-05-05T08:26:08.250029
---
This is a well-structured series (v4, 11 patches) by Luca Ceresoli as part of the ongoing DRM bridge hotplug refcounting work. It introduces `of_drm_get_bridge_by_endpoint()` as a simpler, refcounted replacement for bridge-only callers of the deprecated `drm_of_find_panel_or_bridge()`, then converts all such callers and finally forbids new bridge-only usage of the old API.
The series is logically ordered: infrastructure first (patches 1-2), conversions next (patches 3-10), enforcement last (patch 11). Most patches have already been reviewed/acked by Dmitry Baryshkov. The conversion patterns are consistent and correct, properly handling the bridge refcounting lifecycle.
**There is one compile-breaking bug in patch 2** (the non-OF stub) that must be fixed before merging.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-04 22:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 10:45 [PATCH v4 00/11] drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge() Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 01/11] drm/bridge: drm_bridge_get/put(): ignore ERR_PTR Luca Ceresoli
2026-05-04 13:53 ` Laurent Pinchart
2026-05-04 14:13 ` Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 02/11] drm/bridge: add of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-04 14:55 ` Laurent Pinchart
2026-05-04 15:03 ` Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 03/11] drm/msm/hdmi: switch to of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 04/11] drm/hisilicon/kirin: " Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 05/11] drm/bridge: chrontel-ch7033: " Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 06/11] drm/bridge: lontium-lt9611uxc: " Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 07/11] drm/bridge: lt9611: " Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 08/11] drm/bridge: adv7511: " Luca Ceresoli
2026-05-04 15:22 ` Laurent Pinchart
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 09/11] drm/bridge: lt8713sx: " Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 10/11] drm: zynqmp_dp: " Luca Ceresoli
2026-05-04 15:24 ` Laurent Pinchart
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 11/11] drm: of: forbid bridge-only calls to drm_of_find_panel_or_bridge() Luca Ceresoli
2026-05-04 15:27 ` Laurent Pinchart
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 22:26 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260504-drm-bridge-alloc-getput-panel_or_bridge-v4-0-b578c3daaf10@bootlin.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox