From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: drm_bridge_get/put(): ignore ERR_PTR
Date: Tue, 05 May 2026 08:26:08 +1000 [thread overview]
Message-ID: <review-patch1-20260504-drm-bridge-alloc-getput-panel_or_bridge-v4-1-b578c3daaf10@bootlin.com> (raw)
In-Reply-To: <20260504-drm-bridge-alloc-getput-panel_or_bridge-v4-1-b578c3daaf10@bootlin.com>
Patch Review
**Status: Good**
Clean, minimal change. Switches the NULL guard to `IS_ERR_OR_NULL()` in both `drm_bridge_get()` and `drm_bridge_put()`, matching the pattern used by `kfree()` and similar kernel APIs. This is a prerequisite for the new API returning ERR_PTR on failure.
```c
- if (bridge)
+ if (!IS_ERR_OR_NULL(bridge))
kref_get(&bridge->refcount);
```
The existing `DEFINE_FREE(drm_bridge_put, struct drm_bridge *, if (_T) drm_bridge_put(_T))` in drm_bridge.h uses `if (_T)` (NULL-only check), but this is fine: for ERR_PTR values `_T` is non-NULL, so `drm_bridge_put()` is called, and after this patch it will safely bail out via `IS_ERR_OR_NULL`. No issue here, just noting the interaction.
Reviewed-by tags and Suggested-by are appropriate.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 22:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 10:45 [PATCH v4 00/11] drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge() Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 01/11] drm/bridge: drm_bridge_get/put(): ignore ERR_PTR Luca Ceresoli
2026-05-04 13:53 ` Laurent Pinchart
2026-05-04 14:13 ` Luca Ceresoli
2026-05-04 22:26 ` Claude Code Review Bot [this message]
2026-05-04 10:45 ` [PATCH v4 02/11] drm/bridge: add of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-04 14:55 ` Laurent Pinchart
2026-05-04 15:03 ` Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 03/11] drm/msm/hdmi: switch to of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 04/11] drm/hisilicon/kirin: " Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 05/11] drm/bridge: chrontel-ch7033: " Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 06/11] drm/bridge: lontium-lt9611uxc: " Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 07/11] drm/bridge: lt9611: " Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 08/11] drm/bridge: adv7511: " Luca Ceresoli
2026-05-04 15:22 ` Laurent Pinchart
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 09/11] drm/bridge: lt8713sx: " Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 10/11] drm: zynqmp_dp: " Luca Ceresoli
2026-05-04 15:24 ` Laurent Pinchart
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 10:45 ` [PATCH v4 11/11] drm: of: forbid bridge-only calls to drm_of_find_panel_or_bridge() Luca Ceresoli
2026-05-04 15:27 ` Laurent Pinchart
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot
2026-05-04 22:26 ` Claude review: drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge() Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260504-drm-bridge-alloc-getput-panel_or_bridge-v4-1-b578c3daaf10@bootlin.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox