From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Consistently define pci_device_ids using named initializers
Date: Tue, 05 May 2026 08:10:52 +1000 [thread overview]
Message-ID: <review-overall-20260504150537.2136760-2-u.kleine-koenig@baylibre.com> (raw)
In-Reply-To: <20260504150537.2136760-2-u.kleine-koenig@baylibre.com>
Overall Series Review
Subject: drm: Consistently define pci_device_ids using named initializers
Author: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?=
<u.kleine-koenig@baylibre.com>
Patches: 1
Reviewed: 2026-05-05T08:10:52.264043
---
This is a single-patch cleanup that converts four DRM drivers' `pci_device_id` tables from positional initializers to named initializers using the `PCI_DEVICE` / `PCI_VDEVICE` macros and `.driver_data =` syntax. The change is purely mechanical and well-motivated: it improves readability and prepares for a future change to make `driver_data` an anonymous union (which requires named initializers).
The author states binary equivalence was verified on x86 and arm64, which is the right level of testing for this kind of change.
**Recommendation: This patch looks correct and ready to merge.** One minor nit below on the qxl conversion.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-04 22:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 15:05 [PATCH] drm: Consistently define pci_device_ids using named initializers Uwe Kleine-König (The Capable Hub)
2026-05-04 22:10 ` Claude review: " Claude Code Review Bot
2026-05-04 22:10 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260504150537.2136760-2-u.kleine-koenig@baylibre.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox