Claude review: drm/atomic: track individual colorop updates

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/atomic: track individual colorop updates
Author: Melissa Wen <mwen@igalia.com>
Patches: 7
Reviewed: 2026-05-07T13:05:37.464407

---

This is a well-structured v5 series that addresses a real functional bug: colorop property updates (e.g., shaper/3D LUT changes for gamescope night mode) were not triggering driver-level color block reprogramming. The series is logically decomposed into three pairs:

1. **Patches 1-2**: Scope colorop state tracking to only the *active* color pipeline (optimization + correctness)
2. **Patches 3-4**: Make `lut1d_interpolation` and `lut3d_interpolation` properly mutable by moving them from `drm_colorop` (immutable object) to `drm_colorop_state` (per-commit state)
3. **Patches 5-6**: Add `color_mgmt_changed` tracking for plane colorop changes and wire it into the AMD display driver

The series is clean, the ordering is correct (each patch builds on the prior), and the approach of reusing the existing `color_mgmt_changed` pattern from CRTC state is sound. One notable concern: the `goto err` label introduced in patch 2 is shared with other cases in the switch, which could have unintended side effects if future cases are added between the COLOROP case and the label. Otherwise, the series looks good.

---

---
Generated by Claude Code Patch Reviewer