From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/atomic: track individual colorop updates
Date: Thu, 07 May 2026 13:05:38 +1000 [thread overview]
Message-ID: <review-patch5-20260506192633.16066-6-mwen@igalia.com> (raw)
In-Reply-To: <20260506192633.16066-6-mwen@igalia.com>
Patch Review
**Assessment: Good, one design observation**
This is the core patch that wires up `color_mgmt_changed` tracking. The approach is clean:
1. `drm_atomic_set_colorop_for_plane()` now returns `bool` (true if pipeline changed) and the caller uses `|=` to accumulate into `plane_state->color_mgmt_changed`.
2. `drm_atomic_colorop_set_property()` and `drm_atomic_color_set_data_property()` gain a `bool *replaced` output parameter to signal when a property value actually changed.
3. In `drm_atomic_set_property()`, after setting a colorop property:
```c
if (!ret && replaced)
plane_state->color_mgmt_changed = true;
```
The change detection in `drm_atomic_colorop_set_property()` correctly checks each property individually:
```c
if (state->bypass != val) {
state->bypass = val;
*replaced = true;
}
```
**Design observation**: The `replaced` variable is initialized to `false` but only set to `true` — it's never checked before being returned. For `drm_atomic_color_set_data_property()`, the `replaced` pointer is forwarded directly to `drm_property_replace_blob_from_id()`, which handles blob comparison internally. This is correct because `drm_property_replace_blob_from_id()` already sets `*replaced` to indicate whether the blob pointer changed.
**Observation about `drm_atomic_set_colorop_for_plane()`**: The early return `if (plane_state->color_pipeline == colorop) return false` is a nice optimization — it avoids the debug prints for no-op pipeline selections. However, this changes behavior slightly: previously, the debug message would fire even for redundant sets. This is fine since it's debug-only.
The `#include <linux/types.h>` in `drm_atomic_uapi.h` for `bool` is correct and matches the v2 changelog note about fixing the MSM driver build.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-07 3:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 19:23 [PATCH v5 0/6] drm/atomic: track individual colorop updates Melissa Wen
2026-05-06 19:23 ` [PATCH v5 1/6] drm/atomic: only add colorop state from active color pipeline Melissa Wen
2026-05-07 3:05 ` Claude review: " Claude Code Review Bot
2026-05-06 19:23 ` [PATCH v5 2/6] drm/atomic: don't set colorop properties of inactive color pipelines Melissa Wen
2026-05-07 3:05 ` Claude review: " Claude Code Review Bot
2026-05-06 19:23 ` [PATCH v5 3/6] drm/colorop: Remove read-only comments from interpolation fields Melissa Wen
2026-05-07 3:05 ` Claude review: " Claude Code Review Bot
2026-05-06 19:23 ` [PATCH v5 4/6] drm/colorop: make lut(1/3)d_interpolation mutable Melissa Wen
2026-05-07 3:05 ` Claude review: " Claude Code Review Bot
2026-05-06 19:23 ` [PATCH v5 5/6] drm/atomic: track individual colorop updates Melissa Wen
2026-05-07 3:05 ` Claude Code Review Bot [this message]
2026-05-06 19:23 ` [PATCH v5 6/6] drm/amd/display: use plane color_mgmt_changed to track colorop changes Melissa Wen
2026-05-07 3:05 ` Claude review: " Claude Code Review Bot
2026-05-07 3:05 ` Claude review: drm/atomic: track individual colorop updates Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-01 13:06 [PATCH v4 0/6] drm/atomic: track colorop changes of a given plane Melissa Wen
2026-05-01 13:06 ` [PATCH v4 5/6] drm/atomic: track individual colorop updates Melissa Wen
2026-05-04 23:26 ` Claude review: " Claude Code Review Bot
2026-03-23 13:15 [PATCH v2 0/2] drm/atomic: track colorop changes of a given plane Melissa Wen
2026-03-23 13:15 ` [PATCH v2 1/2] drm/atomic: track individual colorop updates Melissa Wen
2026-03-24 21:51 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260506192633.16066-6-mwen@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox