Claude review: rust: drm: Higher-Ranked Lifetime private data

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: rust: drm: Higher-Ranked Lifetime private data
Author: Danilo Krummrich <dakr@kernel.org>
Patches: 7
Reviewed: 2026-05-07T12:45:08.215356

---

This is a well-structured 6-patch series from Danilo Krummrich that adds lifetime-safe access to parent bus device state from DRM ioctl handlers in the Rust DRM abstractions. The core problem is real and important: DRM ioctls run in process context with no guarantee the parent bus device is still bound, so drivers need a safe mechanism to check/guard against unbinding.

The design is sound:
1. **Type-level parent device declaration** (patch 1) — ensures the DRM device knows its parent bus type at compile time.
2. **UnbindGuard** (patch 2) — wraps `drm_dev_enter/exit` SRCU critical sections, providing a safe Rust guard that proves the device is bound.
3. **RegistrationData with ForLt** (patch 3) — uses higher-ranked lifetimes to store data whose logical lifetime is tied to the device binding scope, with `mem::transmute` for lifetime erasure/recovery.
4. **Ioctl integration** (patches 4-6) — wraps every ioctl dispatch in an UnbindGuard and passes both the bound parent device and registration data to handlers.

The switch from `drm_dev_unregister()` to `drm_dev_unplug()` in patch 2 is the critical enabler — it provides the SRCU barrier that makes the `UnbindGuard` safety argument valid.

**Key dependency**: This series requires both the `ForLt` trait (from a separate series [1]) and Lyude's `drm::DeviceContext` work, neither of which are in the current drm-next tree. The patches cannot be applied standalone.

**Overall**: The design is architecturally sound and well-documented. The safety arguments are carefully stated. I have a few specific concerns noted below.

---
Generated by Claude Code Patch Reviewer