From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: drm: Wrap ioctl dispatch in UnbindGuard
Date: Thu, 07 May 2026 12:45:09 +1000 [thread overview]
Message-ID: <review-patch4-20260506221027.858481-5-dakr@kernel.org> (raw)
In-Reply-To: <20260506221027.858481-5-dakr@kernel.org>
Patch Review
The ioctl macro change:
```rust
let dev = unsafe {
$crate::drm::device::Device::from_raw(raw_dev)
};
let _guard = match $crate::drm::device::unbind_guard(dev) {
Some(g) => g,
None => return $crate::error::code::ENODEV.to_errno(),
};
```
**Free-function wrapper**: The `unbind_guard` free function is a reasonable workaround for macro type inference limitations. It's marked `#[doc(hidden)]` appropriately.
**ENODEV return**: Returning `ENODEV` when the device has been unplugged is the standard behavior for unplugged DRM devices. Correct.
**Guard naming**: The guard is named `_guard` (with underscore prefix) because in this patch it's not used for anything other than keeping the critical section open. This changes in patch 5 where it becomes `guard`. Clean incremental development.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-07 2:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 22:05 [PATCH 0/6] rust: drm: Higher-Ranked Lifetime private data Danilo Krummrich
2026-05-06 22:05 ` [PATCH 1/6] rust: drm: Add Driver::ParentDevice associated type Danilo Krummrich
2026-05-07 2:45 ` Claude review: " Claude Code Review Bot
2026-05-06 22:06 ` [PATCH 2/6] rust: drm: Add UnbindGuard for drm_dev_enter/exit critical sections Danilo Krummrich
2026-05-07 2:45 ` Claude review: " Claude Code Review Bot
2026-05-06 22:06 ` [PATCH 3/6] rust: drm: Add RegistrationData to drm::Driver Danilo Krummrich
2026-05-07 2:45 ` Claude review: " Claude Code Review Bot
2026-05-06 22:06 ` [PATCH 4/6] rust: drm: Wrap ioctl dispatch in UnbindGuard Danilo Krummrich
2026-05-07 2:45 ` Claude Code Review Bot [this message]
2026-05-06 22:06 ` [PATCH 5/6] rust: drm: Pass registration data to ioctl handlers Danilo Krummrich
2026-05-07 2:45 ` Claude review: " Claude Code Review Bot
2026-05-06 22:06 ` [PATCH 6/6] rust: drm: Pass bound parent device " Danilo Krummrich
2026-05-07 2:45 ` Claude review: " Claude Code Review Bot
2026-05-07 2:45 ` Claude review: rust: drm: Higher-Ranked Lifetime private data Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260506221027.858481-5-dakr@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox