From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/pm: Use guard(mutex) instead of manual lock+unlock
Date: Sat, 16 May 2026 12:18:25 +1000 [thread overview]
Message-ID: <review-overall-20260508024744.6523-1-andrejhirata@usp.br> (raw)
In-Reply-To: <20260508024744.6523-1-andrejhirata@usp.br>
Overall Series Review
Subject: drm/amd/pm: Use guard(mutex) instead of manual lock+unlock
Author: Andre Hirata <andrejhirata@usp.br>
Patches: 16
Reviewed: 2026-05-16T12:18:25.965626
---
This mbox contains three versions of the same single patch (RESEND/v1, v2, v3) converting `drivers/gpu/drm/amd/pm/amdgpu_dpm.c` from manual `mutex_lock`/`mutex_unlock` pairs to the kernel `guard(mutex)` and `scoped_guard(mutex)` cleanup API. The v3 is the latest and has a `Reviewed-by: Christian König`.
The intent is good and the overall direction is correct -- using `guard()` eliminates a class of lock-leak bugs on early returns. However, **v3 has several build-breaking syntax errors and one logic inversion bug** that must be fixed before it can be applied. The patch will not compile as-is.
**Verdict: Needs a v4 to fix the issues below.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 2:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 2:47 [PATCH RESEND] drm/amd/pm: Use guard(mutex) instead of manual lock+unlock Andre Hirata
2026-05-08 8:43 ` Christian König
2026-05-08 10:36 ` Andre Jun Hirata
2026-05-08 11:12 ` [PATCH v2] " Andre Jun Hirata
2026-05-08 12:44 ` Christian König
2026-05-08 14:21 ` [PATCH v3] " Andre Jun Hirata
2026-05-08 17:23 ` [PATCH v4] " Andre Jun Hirata
2026-05-08 23:03 ` [PATCH v5] " Andre Jun Hirata
2026-05-11 4:58 ` Wang, Yang(Kevin)
2026-05-11 12:42 ` [PATCH v6] " Andre Jun Hirata
2026-05-11 13:50 ` Lazar, Lijo
2026-05-12 23:04 ` [PATCH v7] " Andre Jun Hirata
2026-05-13 5:38 ` [PATCH v8] " Andre Jun Hirata
2026-05-13 4:39 ` [PATCH v5] " kernel test robot
2026-05-13 6:12 ` kernel test robot
2026-05-13 5:11 ` [PATCH v4] " kernel test robot
2026-05-16 2:18 ` Claude Code Review Bot [this message]
2026-05-16 2:18 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260508024744.6523-1-andrejhirata@usp.br \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox