Claude review: accel/rocket: fix ignored return value in rocket_ioctl_submit

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: accel/rocket: fix ignored return value in rocket_ioctl_submit
Author: Kartik Nair <contact.kartikn@gmail.com>
Patches: 1
Reviewed: 2026-05-16T16:08:43.322827

---

This is a single-patch fix for the `accel/rocket` driver where `rocket_ioctl_submit()` was ignoring the return value of `rocket_ioctl_submit_job()`. The bug is real — without this fix, a failed job submission is silently swallowed and userspace receives a success return code despite the failure. The fix is correct, minimal, and follows the existing error-handling pattern already used in the same function (the `copy_from_user` loop above uses the identical `goto exit` pattern).

**Verdict: The patch looks good.**

One minor observation worth noting, but not necessarily a blocker: when a job fails partway through a multi-job submission, the jobs that were already successfully submitted (pushed to the scheduler) will still execute. This is arguably the correct behavior — `rocket_ioctl_submit_job()` fully owns each job's lifecycle (it cleans up on error, and pushes to the scheduler on success) — but the caller has no way to cancel previously submitted jobs. Whether this is a problem depends on the userspace API contract. The original code had the same issue (it submitted all jobs regardless of failures), so this patch is strictly an improvement.

---
Generated by Claude Code Patch Reviewer