Claude review: accel/rocket: fix ignored return value in rocket_ioctl_submit

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Correctness: Good.** The fix correctly captures the return value of `rocket_ioctl_submit_job()` and breaks out of the loop on the first failure, propagating the error to userspace via the existing `exit` label.

The key code change:

```c
-	for (i = 0; i < args->job_count; i++)
-		rocket_ioctl_submit_job(dev, file, &jobs[i]);
+	for (i = 0; i < args->job_count; i++) {
+		ret = rocket_ioctl_submit_job(dev, file, &jobs[i]);
+		if (ret)
+			goto exit;
+	}
```

**No resource leak concerns.** Looking at `rocket_ioctl_submit_job()` (line 533–588), it is fully self-contained with respect to resource management: on error, it cleans up the scheduler job and puts the job reference before returning. On success, the job is pushed to the scheduler and also properly ref-counted. So skipping subsequent jobs after a failure doesn't leak anything — the `jobs` array is just userspace-copied data (`struct drm_rocket_job` values), freed at the `exit` label via `kvfree(jobs)`.

**Pattern consistency.** The fix mirrors the error-handling style of the `copy_from_user` loop immediately above (lines 617–625), which also uses `goto exit` on failure. This is clean and consistent.

**Commit message.** Clear and accurate. Describes the problem (ignored return value, silent error), the consequence (success returned to userspace, inconsistent state), and the fix (propagate error, break on failure).

**Reviewed-by worthy.** No issues found. This is a straightforward, correct bugfix.

---
Generated by Claude Code Patch Reviewer