public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/dp/mst: fix OOB reads on 2-byte fields in sideband reply parsers
Date: Sat, 16 May 2026 16:05:47 +1000	[thread overview]
Message-ID: <review-overall-20260510203128.2884846-1-ashutoshdesai993@gmail.com> (raw)
In-Reply-To: <20260510203128.2884846-1-ashutoshdesai993@gmail.com>

Overall Series Review

Subject: drm/dp/mst: fix OOB reads on 2-byte fields in sideband reply parsers
Author: Ashutosh Desai <ashutoshdesai993@gmail.com>
Patches: 1
Reviewed: 2026-05-16T16:05:47.888904

---

This is a single-patch fix for out-of-bounds reads in three DP MST sideband reply parsers. The core problem is real: when reading 16-bit fields as `(raw->msg[idx] << 8) | raw->msg[idx+1]`, the preceding bounds check `idx > raw->curlen` only validates the first byte, not the second. The fix — changing to `idx + 2 > raw->curlen` — is correct and minimal.

However, the patch misses the **same bug** in a fourth function in the same file, and the commit message slightly overstates the practical consequence of the OOB read.

**Verdict**: The fix itself is correct but incomplete. The same 2-byte read pattern with insufficient bounds checking exists in `drm_dp_sideband_parse_resource_status_notify()` at line 1127, which should be fixed in the same patch (or a follow-up mentioned in the cover letter).

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  6:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-10 20:31 [PATCH v2] drm/dp/mst: fix OOB reads on 2-byte fields in sideband reply parsers Ashutosh Desai
2026-05-16  6:05 ` Claude Code Review Bot [this message]
2026-05-16  6:05 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-10  4:00 [PATCH] " Ashutosh Desai
2026-04-12  0:31 ` Claude review: " Claude Code Review Bot
2026-04-12  0:31 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260510203128.2884846-1-ashutoshdesai993@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox