Claude review: drm/atomic: determine the hotspots attribute first

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/atomic: determine the hotspots attribute first
Author: yaolu@kylinos.cn
Patches: 1
Reviewed: 2026-05-16T15:55:01.344626

---

This is a single-patch series that reorders the `if-else` chain in `drm_atomic_plane_set_property()` and `drm_atomic_plane_get_property()` so that the hotspot property checks happen *before* the driver `atomic_set/get_property` callback fallback.

**The fix is logically correct.** The driver callback is a catch-all fallback for driver-specific properties and should always come last, just before the "unknown property" error case. Having it in the middle of core property checks was a latent bug — if any driver with `DRIVER_CURSOR_HOTSPOT` also implemented `plane->funcs->atomic_set_property`, the hotspot properties would be swallowed by the driver callback and never reach the core handling code.

**Practical impact is currently low.** I checked the four drivers that set `DRIVER_CURSOR_HOTSPOT` (vmwgfx, virtio-gpu, vboxvideo, qxl) and none of them implement plane-level `atomic_set/get_property`. vmwgfx has connector-level callbacks only. So this is a defensive fix against a currently-theoretical bug, but still worth doing — the ordering was clearly wrong and fragile.

**The commit message and metadata need significant improvement** before this should be merged.

---
Generated by Claude Code Patch Reviewer