public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu/drm: tegra: add DSI support for Tegra20/Tegra30
Date: Sat, 16 May 2026 15:48:58 +1000	[thread overview]
Message-ID: <review-overall-20260511074538.24563-1-clamor95@gmail.com> (raw)
In-Reply-To: <20260511074538.24563-1-clamor95@gmail.com>

Overall Series Review

Subject: gpu/drm: tegra: add DSI support for Tegra20/Tegra30
Author: Svyatoslav Ryhel <clamor95@gmail.com>
Patches: 3
Reviewed: 2026-05-16T15:48:58.584162

---

This is a well-structured 2-patch series adding DSI support for Tegra20/Tegra30 to the existing Tegra DSI driver. The approach is sound: introduce a per-SoC config struct with boolean flags to gate the hardware differences (pad control registers and clock muxing), then make `clk_lp` optional since Tegra20/Tegra30 don't have it. The second patch re-introduces a bootloader-DSI workaround with better placement. Both patches have a Reviewed-by from Mikko Perttunen and the author has tested on real hardware across multiple SoC generations.

**Overall assessment: Series looks good with minor issues.**

The primary concern is in patch 2 where `tegra_dsi_disable()` is called unconditionally — including on ganged-mode setups where `dsi->slave` may not be initialized yet — and the comment style doesn't match kernel conventions. Patch 1 is clean and well-factored.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  5:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  7:45 [PATCH v4 0/2 RESEND] gpu/drm: tegra: add DSI support for Tegra20/Tegra30 Svyatoslav Ryhel
2026-05-11  7:45 ` [PATCH v4 1/2 RESEND] drm/tegra: dsi: add " Svyatoslav Ryhel
2026-05-16  5:48   ` Claude review: " Claude Code Review Bot
2026-05-11  7:45 ` [PATCH v4 2/2 RESEND] drm/tegra: dsi: re-add clear enable register if DSI was powered by bootloader Svyatoslav Ryhel
2026-05-16  5:48 ` Claude Code Review Bot [this message]
2026-05-16  5:48 ` Claude review: gpu/drm: tegra: add DSI support for Tegra20/Tegra30 Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-09  7:52 [PATCH v4 0/2] " Svyatoslav Ryhel
2026-03-10  2:38 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260511074538.24563-1-clamor95@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox