Claude review: drm: Improve logic behind damage handling

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm: Improve logic behind damage handling
Author: Thomas Zimmermann <tzimmermann@suse.de>
Patches: 11
Reviewed: 2026-05-16T15:34:43.959666

---

This is a well-structured cleanup series from Thomas Zimmermann that consolidates and simplifies the DRM damage clipping logic. The core problem is real: damage evaluation was happening at the wrong point in the atomic check pipeline (before driver atomic_check could trigger modesets), leading to inconsistent state visible to different pipeline stages and drivers working around the framework.

The approach is sound:
1. Stop mutating `fb_damage_clips`; use the `ignore_damage_clips` flag instead (patch 1)
2. Move damage evaluation to after all atomic_check helpers (patches 2, 4, 8)
3. Clean up drivers that no longer need old_state (patches 3, 5, 6, 7, 10)
4. Cosmetic rename (patch 9)

The series is generally clean and correct. There are a few observations below, one being a potential resource leak bug in the appletbdrm patch. The removal of unit tests in patch 4 is justified since the src-moved tests now exercise a different code path (the check happens at check time, not iter_init time).

**Recommendation**: Mostly looks good. One bug to fix in patch 5 (appletbdrm error path leak), and a minor nit on patch ordering. Otherwise, ready for merge after addressing those.

---
Generated by Claude Code Patch Reviewer