public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/damage-helper: Test src coord in drm_atomic_helper_check_plane_damage()
Date: Sat, 16 May 2026 15:34:45 +1000	[thread overview]
Message-ID: <review-patch4-20260511122421.114014-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20260511122421.114014-5-tzimmermann@suse.de>

Patch Review

**Correctness**: This moves the `drm_rect_equals(&state->src, &old_state->src)` check from `drm_atomic_helper_damage_iter_init()` (commit time) to `drm_atomic_helper_check_plane_damage()` (check time). This is the right place for it because:
- The check requires the old plane state, which should be available during atomic_check but shouldn't need to be threaded through to commit-time helpers.
- Setting `ignore_damage_clips` at check time gives a consistent view to all downstream consumers.

The function signature changes from `(state, plane_state)` to `(state, old_plane_state, new_plane_state)` which is consistent.

**Test removals**: 6 tests are dropped (`*_src_moved`, `*_fractional_src_moved`, `*_damage_not_visible` with src moved). This is appropriate because those tests were testing the src-comparison logic inside `damage_iter_init`, which no longer exists there. The `drm_test_damage_iter_damage_ignore` test from patch 1 covers the equivalent behavior via the flag.

However, I note the `drm_test_damage_iter_damage_not_visible` test is also removed here. This test had `mock->state.visible = false` *and* moved src coords. The `visible = false` case is still covered by the existing `drm_test_damage_iter_no_damage_not_visible` test (which doesn't move src), so no coverage gap.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  5:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 12:22 [PATCH v2 00/10] drm: Improve logic behind damage handling Thomas Zimmermann
2026-05-11 12:22 ` [PATCH v2 01/10] drm/damage-helper: Do not alter damage clips on modeset, but ignore them Thomas Zimmermann
2026-05-16  5:34   ` Claude review: " Claude Code Review Bot
2026-05-11 12:22 ` [PATCH v2 02/10] drm/atomic-helpers: Evaluate plane damage after atomic_check Thomas Zimmermann
2026-05-16  5:34   ` Claude review: " Claude Code Review Bot
2026-05-11 12:22 ` [PATCH v2 03/10] drm/ingenic: Remove calls to drm_atomic_helper_check_plane_damage() Thomas Zimmermann
2026-05-16  5:34   ` Claude review: " Claude Code Review Bot
2026-05-11 12:22 ` [PATCH v2 04/10] drm/damage-helper: Test src coord in drm_atomic_helper_check_plane_damage() Thomas Zimmermann
2026-05-16  5:34   ` Claude Code Review Bot [this message]
2026-05-11 12:22 ` [PATCH v2 05/10] drm/appletbdrm: Allocate request/response buffers in begin_fb_access Thomas Zimmermann
2026-05-16  5:34   ` Claude review: " Claude Code Review Bot
2026-05-11 12:22 ` [PATCH v2 06/10] drm/damage-helper: Remove old state from drm_atomic_helper_damage_iter_init() Thomas Zimmermann
2026-05-16  5:34   ` Claude review: " Claude Code Review Bot
2026-05-11 12:22 ` [PATCH v2 07/10] drm/damage-helper: Remove old state from drm_atomic_helper_damage_merged() Thomas Zimmermann
2026-05-16  5:34   ` Claude review: " Claude Code Review Bot
2026-05-11 12:22 ` [PATCH v2 08/10] drm/atomic_helper: Do not evaluate plane damage before atomic_check Thomas Zimmermann
2026-05-16  5:34   ` Claude review: " Claude Code Review Bot
2026-05-11 12:22 ` [PATCH v2 09/10] drm/damage-helper: Rename state parameters in damage helpers Thomas Zimmermann
2026-05-16  5:34   ` Claude review: " Claude Code Review Bot
2026-05-11 12:22 ` [PATCH v2 10/10] drm/vmwgfx: Remove unused field struct vmwgfx_du_update_plane.old_state Thomas Zimmermann
2026-05-16  5:34   ` Claude review: " Claude Code Review Bot
2026-05-16  5:34 ` Claude review: drm: Improve logic behind damage handling Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260511122421.114014-5-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox