From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu/buddy: Per-order free and used block scoreboards
Date: Sat, 16 May 2026 14:58:07 +1000 [thread overview]
Message-ID: <review-overall-20260511164217.150237-1-francois.dugast@intel.com> (raw)
In-Reply-To: <20260511164217.150237-1-francois.dugast@intel.com>
Overall Series Review
Subject: gpu/buddy: Per-order free and used block scoreboards
Author: Francois Dugast <francois.dugast@intel.com>
Patches: 5
Reviewed: 2026-05-16T14:58:07.515061
---
This is a well-structured 3-patch series against the `gpu_buddy` allocator. Patch 1 fixes a real use-after-free / rbtree corruption bug in four error-undo paths, patches 2 and 3 add per-order free and used block scoreboards to make `drm_buddy_print()` / `gpu_buddy_print()` O(1) instead of O(n).
The bug fix in patch 1 is correct and follows the established pattern from `__force_merge()`. The scoreboard accounting in patches 2 and 3 is carefully placed at every state-transition point and I was unable to find a path that would cause a missed increment, double-decrement, or underflow.
**Overall: series looks good, with minor nits below.**
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 4:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 16:41 [PATCH v2 0/3] gpu/buddy: Per-order free and used block scoreboards Francois Dugast
2026-05-11 16:41 ` [PATCH v2 1/3] gpu/buddy: Fix use-after-free in split_block() call sites Francois Dugast
2026-05-16 4:58 ` Claude review: " Claude Code Review Bot
2026-05-11 16:41 ` [PATCH v2 2/3] gpu/buddy: Track per-order free blocks with a scoreboard Francois Dugast
2026-05-15 15:50 ` Matthew Auld
2026-05-16 4:58 ` Claude review: " Claude Code Review Bot
2026-05-11 16:41 ` [PATCH v2 3/3] gpu/buddy: Track per-order used " Francois Dugast
2026-05-16 4:58 ` Claude review: " Claude Code Review Bot
2026-05-16 4:58 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-04 13:52 [PATCH 0/2] gpu/buddy: Per-order free and used block scoreboards Francois Dugast
2026-05-04 22:19 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260511164217.150237-1-francois.dugast@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox