Claude review: drm/atomic: Rework initial state allocation

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/atomic: Rework initial state allocation
Author: Maxime Ripard <mripard@kernel.org>
Patches: 21
Reviewed: 2026-05-16T13:22:51.675458

---

This is a well-structured 20-patch series from Maxime Ripard that introduces a new `atomic_create_state` callback pattern for DRM planes, CRTCs, and connectors (previously only available for `drm_private_obj`), and creates a new `drm_mode_config_create_initial_state()` helper to cleanly separate initial state creation from suspend/resume reset.

The motivation is sound: `reset()` is overloaded — used for initial state allocation, hardware reset, and suspend/resume — making it hard to reason about side effects and error handling. The new `atomic_create_state` is fallible, side-effect-free, and purely for state allocation/initialization.

The series is well-ordered: documentation and typo fixes first, then renames (`_reset` -> `_init`), then the new callbacks for each object type, then the central `drm_mode_config_create_initial_state()`, and finally driver conversions (tidss, bridge_connector).

**There is one real bug** in patch 16 — a connector list iterator leak on error. Most other patches are straightforward and correct. The series has good review coverage (Laurent Pinchart, Thomas Zimmermann, Dmitry Baryshkov, Tomi Valkeinen).

---
Generated by Claude Code Patch Reviewer