From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panthor: set __GFP_SKIP_KASAN
Date: Sat, 16 May 2026 13:08:46 +1000 [thread overview]
Message-ID: <review-overall-20260512-panthor-kasan-v1-1-d8d3e275d71b@gmail.com> (raw)
In-Reply-To: <20260512-panthor-kasan-v1-1-d8d3e275d71b@gmail.com>
Overall Series Review
Subject: drm/panthor: set __GFP_SKIP_KASAN
Author: Chia-I Wu via B4 Relay <devnull+olvaffe.gmail.com@kernel.org>
Patches: 3
Reviewed: 2026-05-16T13:08:46.783545
---
This is a single, well-motivated patch that fixes a real KASAN invalid-access bug on CONFIG_KASAN_HW_TAGS=y systems with MTE-capable hardware (recent Snapdragon SoCs). The problem is clearly explained: `shmem_swapin_cluster` can swap in pages belonging to other PROT_MTE mappings using panthor's GFP flags, and without `__GFP_SKIP_KASAN`, the page allocator assigns a specific KASAN tag to the kernel mapping instead of the match-all tag, leading to tag mismatch crashes.
The fix is correct. The approach of deriving the flags from `GFP_HIGHUSER_MOVABLE` rather than directly adding `__GFP_SKIP_KASAN` to the existing expression is a reasonable choice that better matches the semantic intent — these are user-facing pages that should behave like `GFP_HIGHUSER_MOVABLE` except they must not be movable (because panthor pins them).
**Verdict: The patch looks correct and ready for merging**, with minor style observations below.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 3:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 17:36 [PATCH] drm/panthor: set __GFP_SKIP_KASAN Chia-I Wu via B4 Relay
2026-05-13 9:11 ` Boris Brezillon
2026-05-13 18:39 ` Chia-I Wu
2026-05-16 3:08 ` Claude Code Review Bot [this message]
2026-05-16 3:08 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260512-panthor-kasan-v1-1-d8d3e275d71b@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox