Claude review: drm/bridge: it66121: Fix display output on DVI monitors

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/bridge: it66121: Fix display output on DVI monitors
Author: Javier Martinez Canillas <javierm@redhat.com>
Patches: 7
Reviewed: 2026-05-16T13:19:45.709854

---

This is a well-motivated 2-patch series fixing a real bug: the it66121 bridge driver unconditionally sets HDMI TX mode and enables AVI infoframes, which breaks display output on DVI monitors. The approach is sound — patch 1 moves the TX mode/infoframe configuration from `.mode_set` to `.atomic_enable` (where `ctx->connector` is available), and patch 2 makes the configuration conditional on `display_info.is_hdmi`.

However, there is a significant issue: **patch 1 does not remove the existing TX mode and AVI infoframe writes from `.mode_set`**. The new `it66121_set_tx_mode()` function added in `.atomic_enable` duplicates the `IT66121_HDMI_MODE_REG` and `IT66121_AVI_INFO_PKT_REG` writes that remain in `it66121_bridge_mode_set()` (lines 796-803 of the current tree). This means both callbacks write these registers, and the `.mode_set` write (which runs first) still unconditionally sets HDMI mode. The fix in patch 2 only changes the new function in `.atomic_enable`, so the `.mode_set` code will still force HDMI mode before `.atomic_enable` overrides it with the correct value. While the final state should be correct (`.atomic_enable` runs after `.mode_set`), this is confusing and fragile — the duplicate writes should be cleaned up.

The series is otherwise clean and correctly addresses the v2 feedback from Maxime.

---
Generated by Claude Code Patch Reviewer