Claude review: drm/amd/display: convert GPIO translation logic to lookup tables

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/amd/display: convert GPIO translation logic to lookup tables
Author: Guilherme Ivo Bozi <guilherme.bozi@usp.br>
Patches: 10
Reviewed: 2026-05-16T13:03:12.579109

---

This is a well-structured refactoring series that replaces repetitive switch-statement GPIO translation logic across 8 DCN generations with static lookup tables and shared helper functions. The approach is sound: patch 1 introduces the infrastructure (table entry types, macros, and three generic lookup helpers), and patches 2-9 mechanically convert each ASIC.

The series achieves a net reduction of ~760 lines while making the per-ASIC GPIO mappings declarative and easier to audit. The table structures are well-designed with the `check_mask` flag in `gpio_id_offset_entry` to handle both mask-discriminated entries (via `GPIO_MASK_ENTRY`) and simple offset-only entries (via `GPIO_ENTRY`, used by dcn42's per-HPD registers).

Behavioral equivalence is preserved across all conversions. The DDC mask values (e.g., `DDC1DATA_A_MASK` vs `DDC6DATA_A_MASK`) are identical constants (0x100 / 0x1) across all DDC channels in the hardware, so using any one channel's mask macro for all DDC lines is correct. The GSL omission from `gpio_pins[]` in dcn20+ is properly commented and matches the original "not implemented" assert paths. The dcn401 DDC5 commented-out entries match the original code.

Overall: **the series looks good** and is ready to merge with a couple of minor nits below.

---
Generated by Claude Code Patch Reviewer