public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ttm: Support 52-bit PAs in ttm_place
Date: Sat, 16 May 2026 12:38:59 +1000	[thread overview]
Message-ID: <review-overall-20260512223154.18089-1-felix.kuehling@amd.com> (raw)
In-Reply-To: <20260512223154.18089-1-felix.kuehling@amd.com>

Overall Series Review

Subject: drm/ttm: Support 52-bit PAs in ttm_place
Author: Felix Kuehling <felix.kuehling@amd.com>
Patches: 4
Reviewed: 2026-05-16T12:38:59.764368

---

This is a single patch that widens `fpfn` and `lpfn` in `struct ttm_place` from `unsigned` (32-bit) to `unsigned long` to support physical addresses beyond 44 bits (32-bit page numbers × 4KB pages). The motivation is sound — 32-bit page frame numbers limit addressing to 16 TiB, which is increasingly insufficient.

However, **this patch is already superseded by work in drm-next**. The current drm-next tree already has these fields as `uint64_t`:

```c
struct ttm_place {
	uint64_t	fpfn;
	uint64_t	lpfn;
	uint32_t	mem_type;
	uint32_t	flags;
};
```

The `uint64_t` approach in drm-next is **strictly better** than the `unsigned long` proposed here, because `unsigned long` is only 32-bit on 32-bit platforms, providing no improvement there, while `uint64_t` is unconditionally 64-bit.

**Recommendation: NAK — this change has already landed in drm-next with a superior type choice (`uint64_t` vs `unsigned long`).**

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  2:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 22:31 [PATCH] drm/ttm: Support 52-bit PAs in ttm_place Felix Kuehling
2026-05-13  8:08 ` Christian König
2026-05-13 14:15   ` Kuehling, Felix
2026-05-13 15:42     ` Christian König
2026-05-16  2:38 ` Claude Code Review Bot [this message]
2026-05-16  2:39 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-13 14:12 [PATCH v2] " Felix Kuehling
2026-05-16  1:53 ` Claude review: " Claude Code Review Bot
2026-05-16  1:53 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260512223154.18089-1-felix.kuehling@amd.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox