From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ttm: Support 52-bit PAs in ttm_place
Date: Sat, 16 May 2026 11:53:55 +1000 [thread overview]
Message-ID: <review-overall-20260513141253.20410-1-felix.kuehling@amd.com> (raw)
In-Reply-To: <20260513141253.20410-1-felix.kuehling@amd.com>
Overall Series Review
Subject: drm/ttm: Support 52-bit PAs in ttm_place
Author: Felix Kuehling <felix.kuehling@amd.com>
Patches: 6
Reviewed: 2026-05-16T11:53:55.057936
---
This is a single patch (v2) that widens `fpfn` and `lpfn` in `struct ttm_place` from `unsigned` (32-bit) to `uint64_t` (64-bit) to support physical addresses beyond 44 bits (32-bit page number × 4KB page = 44-bit PA).
The change is straightforward and minimal — only the struct definition is modified. However, there is a notable discrepancy between the commit message and the actual code, and the patch lacks accompanying driver-side audit work.
**Note:** The drm-next tree already contains this exact change (`uint64_t` for both fields), so this patch has either already been merged or an equivalent fix landed independently.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 1:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 14:12 [PATCH v2] drm/ttm: Support 52-bit PAs in ttm_place Felix Kuehling
2026-05-13 14:19 ` Christian König
2026-05-13 14:27 ` Kuehling, Felix
2026-05-13 14:50 ` Arunpravin Paneer Selvam
2026-05-13 14:50 ` Tvrtko Ursulin
2026-05-13 15:32 ` Christian König
2026-05-16 1:53 ` Claude review: " Claude Code Review Bot
2026-05-16 1:53 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-12 22:31 [PATCH] " Felix Kuehling
2026-05-16 2:38 ` Claude review: " Claude Code Review Bot
2026-05-16 2:39 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260513141253.20410-1-felix.kuehling@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox