From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: cgroup/dmem: introduce a peak file
Date: Sat, 16 May 2026 11:20:49 +1000 [thread overview]
Message-ID: <review-overall-20260513-dmem_peak-v2-1-dac06999db9e@igalia.com> (raw)
In-Reply-To: <20260513-dmem_peak-v2-1-dac06999db9e@igalia.com>
Overall Series Review
Subject: cgroup/dmem: introduce a peak file
Author: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Patches: 2
Reviewed: 2026-05-16T11:20:49.360654
---
This is a clean, well-scoped single patch that adds a `dmem.peak` cgroup file to the device memory (dmem) cgroup controller, mirroring the existing `memory.peak` pattern. The implementation correctly reuses the existing `dmemcg_limit_show` callback infrastructure and the `page_counter` watermark tracking that is already in place. The patch is minimal and follows established patterns in the codebase.
**Verdict: Looks good overall.** A couple of minor observations below but nothing blocking.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 1:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 18:58 [PATCH v2] cgroup/dmem: introduce a peak file Thadeu Lima de Souza Cascardo
2026-05-13 20:44 ` Tejun Heo
2026-05-16 1:20 ` Claude Code Review Bot [this message]
2026-05-16 1:20 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-14 17:36 [PATCH v3] " Thadeu Lima de Souza Cascardo
2026-05-16 0:32 ` Claude review: " Claude Code Review Bot
2026-05-16 0:32 ` Claude Code Review Bot
2026-05-06 11:58 [PATCH 0/2] " Thadeu Lima de Souza Cascardo
2026-05-06 11:58 ` [PATCH 2/2] " Thadeu Lima de Souza Cascardo
2026-05-07 3:37 ` Claude review: " Claude Code Review Bot
2026-05-07 3:37 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260513-dmem_peak-v2-1-dac06999db9e@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox