public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: display-connector: detect DP state if cable is plugged on boot
Date: Sat, 16 May 2026 11:28:15 +1000	[thread overview]
Message-ID: <review-overall-20260513-dp-connector-hpd-v2-0-42f757bfcbf9@oss.qualcomm.com> (raw)
In-Reply-To: <20260513-dp-connector-hpd-v2-0-42f757bfcbf9@oss.qualcomm.com>

Overall Series Review

Subject: drm/bridge: display-connector: detect DP state if cable is plugged on boot
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 3
Reviewed: 2026-05-16T11:28:15.749364

---

This is a well-targeted 2-patch series from Dmitry Baryshkov fixing a real boot-time HPD detection problem for DisplayPort connectors using the `display-connector` bridge driver. The core issue: if a DP cable is plugged in before the system boots, the HPD GPIO line is already asserted, so no edge interrupt fires, and the DP controller never learns about the connected display.

The approach is sound: (1) defer IRQ enablement from probe to the `hpd_enable` bridge callback, and (2) schedule a work item to send an initial HPD notification for DP connectors. The work_struct is correctly used to avoid a mutex deadlock — `drm_bridge_hpd_enable()` holds `bridge->hpd_mutex` when calling `hpd_enable`, and `drm_bridge_hpd_notify()` also takes that same mutex, so calling it directly from `hpd_enable` would deadlock.

Both patches are clean, minimal, and correctly ordered. A couple of minor issues noted below.

**Verdict: Looks good, minor nits only.**

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  1:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 18:19 [PATCH v2 0/2] drm/bridge: display-connector: detect DP state if cable is plugged on boot Dmitry Baryshkov
2026-05-13 18:19 ` [PATCH v2 1/2] drm/bridge: display-connector: don't autoenable HPD IRQ Dmitry Baryshkov
2026-05-16  1:28   ` Claude review: " Claude Code Review Bot
2026-05-13 18:19 ` [PATCH v2 2/2] drm/bridge: display-connector: trigger initial HPD event for DP Dmitry Baryshkov
2026-05-16  1:28   ` Claude review: " Claude Code Review Bot
2026-05-16  1:28 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-03-14  0:43 [PATCH 0/2] drm/bridge: display-connector: detect DP state if cable is plugged on boot Dmitry Baryshkov
2026-03-16  2:14 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260513-dp-connector-hpd-v2-0-42f757bfcbf9@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox