From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbcon: Use correct type for vc_resize() return value
Date: Sat, 16 May 2026 11:04:07 +1000 [thread overview]
Message-ID: <review-overall-20260514091918.1607234-1-yujiacheng3@huawei.com> (raw)
In-Reply-To: <20260514091918.1607234-1-yujiacheng3@huawei.com>
Overall Series Review
Subject: fbcon: Use correct type for vc_resize() return value
Author: Jiacheng Yu <yujiacheng3@huawei.com>
Patches: 2
Reviewed: 2026-05-16T11:04:07.379093
---
This is a single-patch series that fixes a type mismatch warning in `fbcon_set_disp()`. The variable `ret` was declared as `unsigned long` but stores the `int` return value of `vc_resize()`. The fix is correct, trivial, and clearly explained. The patch eliminates a real `-Wconversion` warning with no functional change.
**Verdict: Looks good.** Minor nit below on the Fixes tag.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 1:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 9:19 [PATCH] fbcon: Use correct type for vc_resize() return value Jiacheng Yu
2026-05-15 7:12 ` Thomas Zimmermann
2026-05-16 1:04 ` Claude Code Review Bot [this message]
2026-05-16 1:04 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260514091918.1607234-1-yujiacheng3@huawei.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox