public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbcon: Use correct type for vc_resize() return value
Date: Sat, 16 May 2026 11:04:07 +1000	[thread overview]
Message-ID: <review-patch1-20260514091918.1607234-1-yujiacheng3@huawei.com> (raw)
In-Reply-To: <20260514091918.1607234-1-yujiacheng3@huawei.com>

Patch Review

**Assessment: Correct and clean.**

The change is straightforward:

```c
-	int rows, cols;
-	unsigned long ret = 0;
+	int rows, cols, ret;
```

This is the right fix. `vc_resize()` is declared in `include/linux/vt_kern.h:46` as returning `int`, so `ret` should be `int`. The usage at line 1494-1496 is:

```c
	ret = vc_resize(vc, cols, rows);

	if (con_is_visible(vc) && !ret)
		update_screen(vc);
```

The `!ret` check works identically for both types when the value comes from `vc_resize()`, so this is purely a type-correctness fix with no behavioral change. The `= 0` initializer is correctly dropped since `ret` is always assigned before use (at line 1494), and every path that reaches line 1494 will set it.

**Minor nit on the Fixes tag:** The commit message claims `Fixes: af0db3c1f898 ("fbdev: Fix vmalloc out-of-bounds write in fast_imageblit")`. That commit title is about `fast_imageblit`, which seems unrelated to the `unsigned long ret` declaration in `fbcon_set_disp()`. I'd recommend the author double-check that the Fixes tag points to the correct commit — it should point to whichever commit introduced the `unsigned long ret` variable in this function. If it was always `unsigned long` since the function's inception, a Fixes tag may not be appropriate at all (a simple cleanup doesn't necessarily need one).

**No other issues.** The patch is minimal, correctly scoped, and the commit message accurately describes the warning being fixed.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  1:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14  9:19 [PATCH] fbcon: Use correct type for vc_resize() return value Jiacheng Yu
2026-05-15  7:12 ` Thomas Zimmermann
2026-05-16  1:04 ` Claude Code Review Bot [this message]
2026-05-16  1:04 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260514091918.1607234-1-yujiacheng3@huawei.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox