From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vmwgfx: Never destroy STDU zero's Screen Target
Date: Sat, 16 May 2026 10:41:44 +1000 [thread overview]
Message-ID: <review-overall-20260514153103.1465013-1-ian.forbes@broadcom.com> (raw)
In-Reply-To: <20260514153103.1465013-1-ian.forbes@broadcom.com>
Overall Series Review
Subject: drm/vmwgfx: Never destroy STDU zero's Screen Target
Author: Ian Forbes <ian.forbes@broadcom.com>
Patches: 1
Reviewed: 2026-05-16T10:41:44.665104
---
This is a single-patch fix for the VMware SVGA Screen Target Display Unit (STDU) driver. The patch addresses a real usability problem: when a VM display goes to sleep and the CRTC is disabled, the Screen Target for display unit 0 gets destroyed, which causes some VMware clients to fail to create a window (since they query existing screen target info to determine window size). Without a window, the user can't provide input to wake the VM.
The fix is simple and narrowly scoped — it adds an early return in `vmw_stdu_crtc_atomic_disable()` for unit 0, preventing the Screen Target from being destroyed. The approach is reasonable and consistent with how the driver already handles the "inactive but enabled" case (the existing early return at lines 446-449).
**Verdict: Looks correct and well-motivated. One minor concern worth discussing below.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 0:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 15:31 [PATCH] drm/vmwgfx: Never destroy STDU zero's Screen Target Ian Forbes
2026-05-16 0:41 ` Claude Code Review Bot [this message]
2026-05-16 0:41 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260514153103.1465013-1-ian.forbes@broadcom.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox