public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdkfd: Fix UML build guards for x86_64-only code
Date: Sat, 16 May 2026 10:39:53 +1000	[thread overview]
Message-ID: <review-overall-20260514170139.335618-1-alex.hung@amd.com> (raw)
In-Reply-To: <20260514170139.335618-1-alex.hung@amd.com>

Overall Series Review

Subject: drm/amdkfd: Fix UML build guards for x86_64-only code
Author: Alex Hung <alex.hung@amd.com>
Patches: 2
Reviewed: 2026-05-16T10:39:53.035340

---

This is a single patch fixing a UML build failure in `amdkfd` by adding `!defined(CONFIG_UML)` guards alongside existing `CONFIG_X86_64` guards. The problem is that UML defines `CONFIG_X86_64` (inheriting the host architecture) but does not provide x86-specific CPU data structures like `cpu_data()` and `cpuinfo_x86`.

The patch is a straightforward and correct fix. All four `CONFIG_X86_64` guard sites that use x86-specific APIs are updated, and the existing `#else` fallback paths handle the non-x86 case appropriately (returning a default value or printing a diagnostic). No x86-specific code sites appear to be missed.

One notable observation: the current drm-next tree still has `depends on !UML` in `drivers/gpu/drm/amd/amdgpu/Kconfig:6`, which would prevent this build failure from occurring. This patch is a companion fix for `e6b71bcdc409 ("drm/amdgpu: Remove UML build exclusion from Kconfig")` — it only becomes necessary once that commit lands. The ordering dependency should be confirmed so the build doesn't break in an intermediate bisection state.

**Verdict: Patch looks correct.** Minor comments below.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  0:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14 17:01 [PATCH] drm/amdkfd: Fix UML build guards for x86_64-only code Alex Hung
2026-05-14 17:19 ` Alex Deucher
2026-05-16  0:39 ` Claude Code Review Bot [this message]
2026-05-16  0:39 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260514170139.335618-1-alex.hung@amd.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox