public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/v3d: Fix CPU job teardown bugs
Date: Sat, 16 May 2026 08:58:36 +1000	[thread overview]
Message-ID: <review-overall-20260515-v3d-cpu-job-leaks-v1-0-7f147cbbf935@igalia.com> (raw)
In-Reply-To: <20260515-v3d-cpu-job-leaks-v1-0-7f147cbbf935@igalia.com>

Overall Series Review

Subject: drm/v3d: Fix CPU job teardown bugs
Author: =?utf-8?q?Ma=C3=ADra_Canal?= <mcanal@igalia.com>
Patches: 3
Reviewed: 2026-05-16T08:58:36.842986

---

This is a clean, well-motivated 2-patch series that fixes real teardown bugs in V3D's CPU job submission path. Both patches are correct, minimal, and well-structured.

**Patch 1** consolidates the CPU job teardown into the kref destructor (`v3d_cpu_job_free`), mirroring the existing `v3d_render_job_free` pattern. This eliminates a use-after-free on the ioctl error path where `cpu_job` was accessed after `v3d_job_cleanup()` had already released it, and also fixes a syncobj leak since the old manual `kvfree()` calls didn't call `drm_syncobj_put()` on each query entry.

**Patch 2** adds the missing `drm_gem_object_put()` for the indirect CSD BO reference acquired by `drm_gem_object_lookup()` in `v3d_get_cpu_indirect_csd_params()`.

The series is correctly ordered — patch 2 builds on the `v3d_cpu_job_free` kref destructor introduced in patch 1. The commit messages are clear and provide good analysis of the bugs.

**Verdict: Both patches look good for merging.** No issues found.

---

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-05-15 22:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 15:07 [PATCH 0/2] drm/v3d: Fix CPU job teardown bugs Maíra Canal
2026-05-15 15:07 ` [PATCH 1/2] drm/v3d: Fix use-after-free of CPU job query arrays on error path Maíra Canal
2026-05-15 22:58   ` Claude review: " Claude Code Review Bot
2026-05-15 15:07 ` [PATCH 2/2] drm/v3d: Release indirect CSD GEM reference on CPU job free Maíra Canal
2026-05-15 22:58   ` Claude review: " Claude Code Review Bot
2026-05-15 22:58 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260515-v3d-cpu-job-leaks-v1-0-7f147cbbf935@igalia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox