public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/v3d: Release indirect CSD GEM reference on CPU job free
Date: Sat, 16 May 2026 08:58:37 +1000	[thread overview]
Message-ID: <review-patch2-20260515-v3d-cpu-job-leaks-v1-2-7f147cbbf935@igalia.com> (raw)
In-Reply-To: <20260515-v3d-cpu-job-leaks-v1-2-7f147cbbf935@igalia.com>

Patch Review

**Analysis of the bug:** `v3d_get_cpu_indirect_csd_params()` calls `drm_gem_object_lookup()` at `v3d_submit.c:497`:

```c
info->indirect = drm_gem_object_lookup(file_priv, indirect_csd.indirect);
```

`drm_gem_object_lookup()` takes a reference on the GEM object, but nowhere in the teardown path was `drm_gem_object_put()` called to release it. This is a straightforward reference leak.

**Fix:**

```c
if (job->indirect_csd.indirect)
	drm_gem_object_put(job->indirect_csd.indirect);
```

The NULL check is appropriate: for non-indirect-CSD job types, `indirect_csd.indirect` will be zero-initialized (the job struct is allocated with `kcalloc` in `v3d_job_allocate`). It also covers the case where `v3d_job_init()` fails before the extension parsing reaches the indirect CSD path.

The placement in `v3d_cpu_job_free()` (the kref destructor from patch 1) is the right spot — it ensures the reference is dropped on both the scheduler path and the ioctl error path.

**No issues found.** Clean and correct.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-15 22:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 15:07 [PATCH 0/2] drm/v3d: Fix CPU job teardown bugs Maíra Canal
2026-05-15 15:07 ` [PATCH 1/2] drm/v3d: Fix use-after-free of CPU job query arrays on error path Maíra Canal
2026-05-15 22:58   ` Claude review: " Claude Code Review Bot
2026-05-15 15:07 ` [PATCH 2/2] drm/v3d: Release indirect CSD GEM reference on CPU job free Maíra Canal
2026-05-15 22:58   ` Claude Code Review Bot [this message]
2026-05-15 22:58 ` Claude review: drm/v3d: Fix CPU job teardown bugs Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260515-v3d-cpu-job-leaks-v1-2-7f147cbbf935@igalia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox