Claude review: drm: Limit DRM_IOCTL_WAIT_VBLANK to vblank interrupts

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm: Limit DRM_IOCTL_WAIT_VBLANK to vblank interrupts
Author: Thomas Zimmermann <tzimmermann@suse.de>
Patches: 12
Reviewed: 2026-05-16T09:20:27.183260

---

This is a well-structured, straightforward series from Thomas Zimmermann that adds the ability to distinguish between hardware vblank interrupts and simulated (software timer) vblank, and uses that distinction to disable the `DRM_IOCTL_WAIT_VBLANK` ioctl for drivers with simulated vblank. The rationale is sound: the WAIT_VBLANK ioctl is meant for synchronizing with actual display refresh, which is meaningless for software timers. The cover letter confirms that major compositors (Mutter, Weston, KWin) don't rely on this ioctl for rate-limiting.

The series is cleanly organized: infrastructure first (patches 1-2), then mechanical driver conversions (patches 3-9). The backward-compatible inline wrapper for `drm_vblank_init()` is a good approach for an incremental migration.

One notable concern: **`DRM_VBLANK_FLAG_SIMULATED` is defined as `BIT(1)`, skipping `BIT(0)`** with no explanation. This is unconventional and should either be `BIT(0)` or have a comment explaining the reservation.

Overall the series looks good and ready for merge with minor nits.

---
Generated by Claude Code Patch Reviewer