public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vblank: Add DRM_VBLANK_FLAG_SIMULATED
Date: Sat, 16 May 2026 09:20:27 +1000	[thread overview]
Message-ID: <review-patch2-20260515120916.333614-3-tzimmermann@suse.de> (raw)
In-Reply-To: <20260515120916.333614-3-tzimmermann@suse.de>

Patch Review

Defines the flag and adds the ioctl check.

**Main concern:** `DRM_VBLANK_FLAG_SIMULATED` is defined as `BIT(1)`:
```c
#define DRM_VBLANK_FLAG_SIMULATED	BIT(1)
```
This skips `BIT(0)` with no comment or reserved `BIT(0)` definition. Either start at `BIT(0)` or add a comment explaining what `BIT(0)` is reserved for. As-is, it looks like an accidental off-by-one.

The ioctl check itself is well-placed:
```c
	vblank = drm_vblank_crtc(dev, pipe);

	if (vblank->flags & DRM_VBLANK_FLAG_SIMULATED)
		return -EOPNOTSUPP;
```
This is after the pipe validation but before any vblank counter manipulation, which is correct. The `-EOPNOTSUPP` error code is consistent with the existing `drm_wait_vblank_supported()` check at the top of the same function.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-15 23:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 11:55 [PATCH 0/9] drm: Limit DRM_IOCTL_WAIT_VBLANK to vblank interrupts Thomas Zimmermann
2026-05-15 11:55 ` [PATCH 1/9] drm/vblank: Add drmm_vblank_init() to indicate managed cleanup Thomas Zimmermann
2026-05-15 23:20   ` Claude review: " Claude Code Review Bot
2026-05-15 11:55 ` [PATCH 2/9] drm/vblank: Add DRM_VBLANK_FLAG_SIMULATED Thomas Zimmermann
2026-05-15 23:20   ` Claude Code Review Bot [this message]
2026-05-15 11:55 ` [PATCH 3/9] drm/amdgpu: vkms: Set DRM_VBLANK_FLAG_SIMULATED Thomas Zimmermann
2026-05-15 23:20   ` Claude review: " Claude Code Review Bot
2026-05-15 11:55 ` [PATCH 4/9] drm/bochs: " Thomas Zimmermann
2026-05-15 23:20   ` Claude review: " Claude Code Review Bot
2026-05-15 11:55 ` [PATCH 5/9] drm/cirrus: " Thomas Zimmermann
2026-05-15 23:20   ` Claude review: " Claude Code Review Bot
2026-05-15 11:55 ` [PATCH 6/9] drm/hypervdrm: " Thomas Zimmermann
2026-05-15 23:20   ` Claude review: " Claude Code Review Bot
2026-05-15 11:55 ` [PATCH 7/9] drm/qxl: " Thomas Zimmermann
2026-05-15 23:20   ` Claude review: " Claude Code Review Bot
2026-05-15 11:55 ` [PATCH 8/9] drm/virtgpu: " Thomas Zimmermann
2026-05-15 23:20   ` Claude review: " Claude Code Review Bot
2026-05-15 11:55 ` [PATCH 9/9] drm/vkms: " Thomas Zimmermann
2026-05-15 23:20   ` Claude review: " Claude Code Review Bot
2026-05-15 15:12 ` [PATCH 0/9] drm: Limit DRM_IOCTL_WAIT_VBLANK to vblank interrupts Michel Dänzer
2026-05-15 16:56   ` Michel Dänzer
2026-05-15 23:20 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260515120916.333614-3-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox