From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/amdxdna: Remove mmap and export support for ubuf
Date: Sat, 16 May 2026 08:56:25 +1000 [thread overview]
Message-ID: <review-overall-20260515155332.743097-1-lizhi.hou@amd.com> (raw)
In-Reply-To: <20260515155332.743097-1-lizhi.hou@amd.com>
Overall Series Review
Subject: accel/amdxdna: Remove mmap and export support for ubuf
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 1
Reviewed: 2026-05-16T08:56:25.802864
---
This is a single patch that removes mmap, vmap, and vunmap support from the `amdxdna_ubuf_dmabuf_ops` and blocks re-export of ubuf-backed GEM objects. The intent is reasonable: ubuf wraps user-pinned pages, and re-exporting or mmapping through the dma-buf is problematic (the user already has direct access to the memory). The patch is small and the deletion side is clean. However, there are two issues worth discussing: dead code left behind, and a poorly named flag.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-15 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 15:53 [PATCH V1] accel/amdxdna: Remove mmap and export support for ubuf Lizhi Hou
2026-05-15 22:56 ` Claude Code Review Bot [this message]
2026-05-15 22:56 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260515155332.743097-1-lizhi.hou@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox