Claude review: drm/msm/snapshot: fix dumping of the unaligned regions

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/msm/snapshot: fix dumping of the unaligned regions
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 1
Reviewed: 2026-05-16T08:44:40.796210

---

This is a single patch fixing the MSM display snapshot code for unaligned register regions (specifically DSI, which has a 4-byte offset). The core fix is correct and well-reasoned: it removes premature alignment in the caller, fixes a 16x memory overallocation bug (`aligned_len * REG_DUMP_ALIGN` where multiplication was used instead of rounding), and adds proper handling for partial trailing rows during both register dumping and printing.

**However, there is a critical debug filter accidentally left in the patch** that makes it unsuitable for merging as-is. The `strcmp(fmt, "dsi%d_ctrl")` check at line 187 will silently skip ALL non-DSI snapshot blocks (DPU, DP, etc.), completely breaking devcoredump for anything other than DSI controllers.

**Verdict: Needs revision** — the debug filter must be removed before merging. The rest of the logic is correct.

---

---
Generated by Claude Code Patch Reviewer