Claude review: drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup
Author: Jonas Karlman <jonas@kwiboo.se>
Patches: 23
Reviewed: 2026-05-18T16:41:44.798866

---

This is a well-structured 22-patch series by Jonas Karlman that cleans up the Synopsys DesignWare HDMI bridge driver (`dw-hdmi.c`). The series is at v6, has been through multiple review rounds, and carries Reviewed-by/Tested-by tags from Neil Armstrong, Nicolas Frattaroli, and Diederik de Haas on most patches.

**Goals achieved:**
1. Simplifies enable/disable by removing the `bridge_is_on` / `dw_hdmi_update_power()` indirection and calling poweron/poweroff directly from atomic_enable/disable
2. Removes stored `previous_mode` by sourcing the adjusted_mode from crtc_state at enable time
3. Fixes a use-after-free on connector cleanup by holding a bridge reference
4. Consolidates CEC notifier handling using generic DRM CEC helpers
5. Moves EDID read from `get_modes` to `detect`/`force`, matching bridge connector behavior
6. Adds HPD debouncing via delayed_work (1100ms) to handle HPD low-voltage pulses for EDID changes
7. Removes RXSENSE handling entirely, simplifying IRQ to HPD-only
8. Merges top/bottom half IRQ handlers since delayed_work is safe from hardirq context

**Overall assessment:** The series is clean, logically ordered, and represents a significant simplification of the dw-hdmi driver. Each patch does one thing and builds on the previous. The two Fixes: patches (01, 02) are appropriate for stable backport. The final state removes ~140 net lines and eliminates several state variables (`bridge_is_on`, `disabled`, `rxsense`, `force`, `phy_mask`, `previous_mode`, `sink_is_hdmi`, `sink_has_audio`, `edid[]`, `cec_notifier_mutex`).

**One concern:** Patch 14 (bridge detect EDID update) is new in v6 and has no Reviewed-by tag, though it's a reasonable temporary measure for bridge connector parity.

---
Generated by Claude Code Patch Reviewer