Claude review: drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup
Author: Jonas Karlman <jonas@kwiboo.se>
Patches: 23
Reviewed: 2026-05-16T16:21:40.996983

---

This is a well-structured 21-patch cleanup series for the `dw-hdmi` bridge driver by Jonas Karlman, part of a larger effort to upstream HDMI 2.0 support for Rockchip RK33xx devices. The series is now at v5 and has collected several reviewed-by tags from Neil Armstrong and Nicolas Frattaroli.

**Theme**: The series simplifies the enable/disable path, fixes hotplug handling, migrates to modern DRM APIs (generic CEC notifier helpers, `display_info` fields), adds HPD debouncing, and removes now-dead RXSENSE machinery. The result is a net deletion of ~130 lines and significantly simpler code.

**Strengths**:
- Logical patch ordering with clean dependencies — early patches set up the ability to remove code in later patches
- Addresses real bugs: scrambler not cleared on hotplug to HDMI 1.4 sink (patch 1), spurious connected events on RX sense change (patch 2), use-after-free on connector cleanup (patch 7), duplicate hotplug uevents (patch 21)
- Good use of the modern `enable_delayed_work`/`disable_delayed_work` APIs and `drmm_connector_hdmi_cec_notifier_register`
- Thorough commit messages, especially patches 2, 16, 17, and 21

**Concerns**: A few minor issues noted below. The most significant is that the `status` parameter to `dw_hdmi_connector_status_update()` (patch 11) goes unused initially, creating a briefly misleading intermediate state. The series also has a typo in patch 21's commit message. No blocking issues found.

**Recommendation**: This series looks good for merging. The new patches in v5 (7, 8, 15, 21) are sensible additions. The UAF fix in patch 7 is particularly important.

---
Generated by Claude Code Patch Reviewer