From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: heaps: use max3 in dma_heap_ioctl
Date: Mon, 18 May 2026 16:01:29 +1000 [thread overview]
Message-ID: <review-overall-20260517172352.3615-2-thorsten.blum@linux.dev> (raw)
In-Reply-To: <20260517172352.3615-2-thorsten.blum@linux.dev>
Overall Series Review
Subject: dma-buf: heaps: use max3 in dma_heap_ioctl
Author: Thorsten Blum <thorsten.blum@linux.dev>
Patches: 1
Reviewed: 2026-05-18T16:01:29.053378
---
This is a single-patch series that is a straightforward, correct cleanup. It replaces `max(max(in_size, out_size), drv_size)` with `max3(in_size, out_size, drv_size)` and adds the corresponding `#include <linux/minmax.h>` header. The change is purely cosmetic — it improves readability with no functional change. All three arguments are the same type (`unsigned int`), so there are no type-promotion concerns with `max3`.
Already has a Reviewed-by from T.J. Mercier.
**Verdict: Looks good. No issues found.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-18 6:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 17:23 [PATCH RESEND v2] dma-buf: heaps: use max3 in dma_heap_ioctl Thorsten Blum
2026-05-18 6:01 ` Claude Code Review Bot [this message]
2026-05-18 6:01 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-27 21:24 [PATCH v2] dma-buf: heaps: use max3() " Thorsten Blum
2026-04-28 3:58 ` Claude review: " Claude Code Review Bot
2026-04-28 3:58 ` Claude Code Review Bot
2026-04-27 17:25 [PATCH] " Thorsten Blum
2026-04-28 4:15 ` Claude review: " Claude Code Review Bot
2026-04-28 4:15 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260517172352.3615-2-thorsten.blum@linux.dev \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox