public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: heaps: use max3 in dma_heap_ioctl
Date: Mon, 18 May 2026 16:01:29 +1000	[thread overview]
Message-ID: <review-patch1-20260517172352.3615-2-thorsten.blum@linux.dev> (raw)
In-Reply-To: <20260517172352.3615-2-thorsten.blum@linux.dev>

Patch Review

**Status: Clean**

The patch does two things:

1. Adds `#include <linux/minmax.h>` (line 16 after patch), which provides the `max3` macro. This is correctly placed in alphabetical order among the existing includes.

2. Replaces the nested `max()` calls:
```c
-	ksize = max(max(in_size, out_size), drv_size);
+	ksize = max3(in_size, out_size, drv_size);
```

All three variables are declared as `unsigned int` at line 138:
```c
unsigned int in_size, out_size, drv_size, ksize;
```

This makes the `max3` call type-safe with no risk of signed/unsigned comparison issues.

The change is functionally equivalent and slightly more readable. No concerns.

**Reviewed-by: Already has R-b from T.J. Mercier.**

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-18  6:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-17 17:23 [PATCH RESEND v2] dma-buf: heaps: use max3 in dma_heap_ioctl Thorsten Blum
2026-05-18  6:01 ` Claude review: " Claude Code Review Bot
2026-05-18  6:01 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-04-27 21:24 [PATCH v2] dma-buf: heaps: use max3() " Thorsten Blum
2026-04-28  3:58 ` Claude review: " Claude Code Review Bot
2026-04-28  3:58 ` Claude Code Review Bot
2026-04-27 17:25 [PATCH] " Thorsten Blum
2026-04-28  4:15 ` Claude review: " Claude Code Review Bot
2026-04-28  4:15 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260517172352.3615-2-thorsten.blum@linux.dev \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox