public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vmwgfx: Fix hrtimer interrupt storm due to 0-period vblank
Date: Mon, 25 May 2026 18:01:51 +1000	[thread overview]
Message-ID: <review-overall-20260518071741.441794-1-w15303746062@163.com> (raw)
In-Reply-To: <20260518071741.441794-1-w15303746062@163.com>

Overall Series Review

Subject: drm/vmwgfx: Fix hrtimer interrupt storm due to 0-period vblank
Author: w15303746062@163.com
Patches: 3
Reviewed: 2026-05-25T18:01:51.532748

---

This is a v1→v2 iteration of a single patch fixing a real DoS vulnerability: userspace can craft a display mode with huge `crtc_clock` and tiny `htotal*vtotal`, causing `drm_calc_timestamping_constants()` to truncate `framedur_ns` to 0. This leads to an infinite hrtimer hard-IRQ loop that locks up the CPU.

The v2 correctly moves the fix from the vmwgfx driver into the DRM core (`drm_crtc_vblank_start_timer()`), which is the right location — the timer setup logic was refactored into the core, so the fix there protects all drivers using software vblank simulation, not just vmwgfx. The v2 also correctly drops `WARN_ON_ONCE()` to avoid `panic_on_warn` issues from unprivileged userspace.

The fix is a reasonable defensive bandaid. A more thorough long-term fix would reject these pathological modes earlier in the pipeline (e.g., in `atomic_check` or mode validation), but as a targeted DoS prevention this is appropriate for stable backport.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-05-25  8:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18  7:17 [PATCH] drm/vmwgfx: Fix hrtimer interrupt storm due to 0-period vblank w15303746062
2026-05-22  8:22 ` Thomas Zimmermann
2026-05-23  2:54   ` [PATCH v2] drm/vblank: Reject 0-period timers to prevent hrtimer storm w15303746062
2026-05-25  8:01   ` Claude review: Re: [PATCH] drm/vmwgfx: Fix hrtimer interrupt storm due to 0-period vblank Claude Code Review Bot
2026-05-25  8:01 ` Claude review: " Claude Code Review Bot
2026-05-25  8:01 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260518071741.441794-1-w15303746062@163.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox