From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vmwgfx: Fix hrtimer interrupt storm due to 0-period vblank
Date: Mon, 25 May 2026 18:01:51 +1000 [thread overview]
Message-ID: <review-patch1-20260518071741.441794-1-w15303746062@163.com> (raw)
In-Reply-To: <20260518071741.441794-1-w15303746062@163.com>
Patch Review
**Superseded by v2.** This patch targets the old code path in `vmw_vkms_enable_vblank()` where the hrtimer was set up directly in the vmwgfx driver. The current tree has refactored this — `vmw_vkms_enable_vblank()` now simply calls `drm_crtc_vblank_start_timer(crtc)` (vmwgfx_vkms.c:259), so this patch no longer applies.
Even if it did apply, fixing only in vmwgfx would leave other drivers using `drm_crtc_vblank_start_timer()` (e.g., vkms) still vulnerable.
The `WARN_ON_ONCE()` usage was also problematic — it lets unprivileged userspace trigger a kernel warning, which is a panic on systems with `panic_on_warn=1`.
**Verdict:** Correctly superseded by v2.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-25 8:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 7:17 [PATCH] drm/vmwgfx: Fix hrtimer interrupt storm due to 0-period vblank w15303746062
2026-05-22 8:22 ` Thomas Zimmermann
2026-05-23 2:54 ` [PATCH v2] drm/vblank: Reject 0-period timers to prevent hrtimer storm w15303746062
2026-05-25 8:01 ` Claude review: Re: [PATCH] drm/vmwgfx: Fix hrtimer interrupt storm due to 0-period vblank Claude Code Review Bot
2026-05-25 8:01 ` Claude review: " Claude Code Review Bot
2026-05-25 8:01 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260518071741.441794-1-w15303746062@163.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox